Stage 2 beta changes for RFC 0040, volume.*#2269
Merged
ebeahan merged 6 commits intoelastic:mainfrom Oct 3, 2023
Merged
Conversation
|
Documentation changes preview: https://ecs_2269.docs-preview.app.elstc.co/diff |
Member
Author
|
@Trinity2019 will you take a look? This PR is required to land the |
ebeahan
force-pushed
the
rfc/0004/apply-stage-2-changes
branch
from
8525b33 to
dfcac64
Compare
Trinity2019
approved these changes
Oct 3, 2023
Contributor
Trinity2019
left a comment
Trinity2019
left a comment
There was a problem hiding this comment.
LGTM. Thanks @ebeahan for moving the proposal into beta stage!
kgeller
approved these changes
Oct 3, 2023
This was referenced Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the changes proposed in RFC 0040 which has advanced to stage 2 (#2260).
These changes add a new
volume.*field set to describe storage volume devices. The field set will be marked asbetasince the RFC is currently at RFC stage 2.