Fix link rendering issues and usage of http in links#2423
Merged
taylor-swanson merged 5 commits intoelastic:mainfrom Jan 17, 2025
Merged
Fix link rendering issues and usage of http in links#2423taylor-swanson merged 5 commits intoelastic:mainfrom
taylor-swanson merged 5 commits intoelastic:mainfrom
Conversation
- Removed link text markup - Replace http with https in links
|
Documentation changes preview: https://ecs_bk_2423.docs-preview.app.elstc.co/diff |
mjwolf
approved these changes
Jan 15, 2025
Contributor
mjwolf
left a comment
There was a problem hiding this comment.
LGTM
I checked that there are no other markdown or asciidoc formatted links in the schema files too
mjwolf
pushed a commit
to mjwolf/ecs
that referenced
this pull request
Jan 17, 2025
…lastic#2423) - Removed link text markup, causes issues since final rendering of docs can be in either markdown or asciidoc - Replace http with https in links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues