Fix: match behavior of declare linter to checkdoc#272
Merged
jcs090218 merged 4 commits intoemacs-eask:masterfrom Oct 30, 2024
Merged
Fix: match behavior of declare linter to checkdoc#272jcs090218 merged 4 commits intoemacs-eask:masterfrom
jcs090218 merged 4 commits intoemacs-eask:masterfrom
Conversation
jcs090218
reviewed
Oct 29, 2024
lisp/lint/declare.el
Outdated
| (eask-lint-first-newline) | ||
| (eask-msg "`%s` with check-declare" (ansi-green file)) | ||
| (setq errors (check-declare-file filename)) | ||
| (setq errors (dlet ((inhibit-message 't)) (check-declare-file filename))) |
Member
There was a problem hiding this comment.
Do you mean let here? 🤔 Maybe we can use eask--silent instead.
Contributor
Author
There was a problem hiding this comment.
Nice, I've used that instead. I thought that you needed dlet to use inhibit-message like that...
jcs090218
approved these changes
Oct 30, 2024
Member
|
Thank you for taking care of this! Merged!🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #271
Summary
check-declare-fileis hiddenAfter the change:
The output line is formatted like an error and the exit code is 1.
Questions
Perhaps 'Warning (check-declare)' should be removed from the output?
e.g. this seems like a better message