Resolve project image to manifest images#40
Merged
Conversation
ernoaapa
force-pushed
the
resolve-proper-image
branch
from
222d168 to
bb992a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 25.48% 25.17% -0.31%
==========================================
Files 50 50
Lines 2433 2415 -18
==========================================
- Hits 620 608 -12
+ Misses 1746 1740 -6
Partials 67 67
Continue to review full report at Codecov.
|
Previously we were using the non-manifest images like 'docker.io/arm64v8/node:latest' when we were resolving project images automatically. Nowadays the 'docker.io/library/node:latest' is manifest image which supports multiple different architectures so we don't need to handle all the cases by ourself.
ernoaapa
force-pushed
the
resolve-proper-image
branch
8 times, most recently
from
8cb3a0b to
79a82b1
Compare
ernoaapa
force-pushed
the
resolve-proper-image
branch
from
79a82b1 to
46eb09e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were using the non-manifest images like
'docker.io/arm64v8/node:latest' when we were resolving project
images automatically.
Nowadays the 'docker.io/library/node:latest' is manifest image
which supports multiple different architectures so we don't
need to handle all the cases by ourself.