Merged
Conversation
ethteck
reviewed
Mar 10, 2025
…_splits_for_objdiff_compatibility
AngheloAlf
changed the title
keep_complete_c_asm_splits_for_objdiff_compatibilitymake_full_disasm_for_code
AngheloAlf
deleted the
keep_complete_c_asm_splits_for_objdiff_compatibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please suggest a better name.When enabled, emits a full
.sfile for eachc/cppsegment besides the generatednonmatchingsindividual functions, which can be used as a "target" or "expected" for asm diffing.It is available as both a yaml option and as a cli parameter.
I also enabled it on the sole test we have.
Fixes #447