fix(optimizer): wrap merged results as predicates#864
Merged
antonmedv merged 3 commits intoexpr-lang:masterfrom Dec 4, 2025
Merged
fix(optimizer): wrap merged results as predicates#864antonmedv merged 3 commits intoexpr-lang:masterfrom
antonmedv merged 3 commits intoexpr-lang:masterfrom
Conversation
Ensure combined predicates in consecutive `filter()` calls are wrapped in a `PredicateNode`. Previously, the optimizer created a raw `BinaryNode` for merged filters, causing type assertion panics. The expr parser generates `filter(array, predicate)` calls only. This fix ensures that the merged predicate is wrapped as an `ast.PredicateNode`. Adds a regression test. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
antonmedv
approved these changes
Nov 28, 2025
Contributor
Author
|
Am I reading this right that this also addresses the OSS-Fuzz finding in #790? btw @antonmedv if you're looking for more eyes on the OSS-Fuzz findings in https://github.com/google/oss-fuzz/blob/master/projects/expr/project.yaml I'd be happy to join 👍 |
Member
Will be nice! Thanks. I will discuss it with other Expr contributors and with Google. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure combined predicates in consecutive
filter()calls are wrapped in anast.PredicateNode. Previously, the optimizer created a rawast.BinaryNodefor merged filters, causing type assertion panics. The expr parser generatesfilter(array, predicate)calls only.This fix ensures that the merged predicate is wrapped as an
ast.PredicateNode. Adds a regression test.Fixes #857