Conversation
|
Comparing: 9724e3e...8f8aaab Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
0979326 to
82c636b
Compare
josephsavona
reviewed
Oct 8, 2025
aaf6158 to
48e2f5b
Compare
josephsavona
reviewed
Oct 8, 2025
5bf9531 to
03c6454
Compare
For 7.0.0: Slim down presets to just 2 configurations: - `recommended`: legacy and flat config with all recommended rules, and - `recommended-latest`: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules Removed: - `recommended-latest-legacy` - `flat/recommended` Please see the README for new install instructions.
josephsavona
reviewed
Oct 8, 2025
| rules: basicRuleConfigs, | ||
| }, | ||
| 'recommended-latest-legacy': { | ||
| recommended: { |
Member
There was a problem hiding this comment.
GH code review is bad so i can't comment on the right lines, but last feedback is that we should actually enable different rules in recommended-latest. maybe your no-void-usememo validation?
This was referenced Oct 8, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
For 7.0.0: Slim down presets to just 2 configurations: - `recommended`: legacy and flat config with all recommended rules, and - `recommended-latest`: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules Removed: - `recommended-latest-legacy` - `flat/recommended` Please see the README for new install instructions. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757). * #34783 * #34782 * __->__ #34757 DiffTrain build for [7568e71](7568e71)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
For 7.0.0: Slim down presets to just 2 configurations: - `recommended`: legacy and flat config with all recommended rules, and - `recommended-latest`: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules Removed: - `recommended-latest-legacy` - `flat/recommended` Please see the README for new install instructions. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757). * #34783 * #34782 * __->__ #34757 DiffTrain build for [7568e71](7568e71)
736-c41-2c1-e464fc974
pushed a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Jan 14, 2026
This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [eslint-plugin-react-hooks](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks)) | devDependencies | major | [`^6.0.0` → `^7.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-react-hooks/6.1.1/7.0.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/facebook/react) | --- ### Release Notes <details> <summary>facebook/react (eslint-plugin-react-hooks)</summary> ### [`v7.0.1`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#701) [Compare Source](facebook/react@4b3e662...408b38e) - Disallowed passing inline `useEffectEvent` values as JSX props to guard against accidental propagation. ([#​34820](facebook/react#34820) by [@​jf-eirinha](https://github.com/jf-eirinha)) - Switch to `export =` so eslint-plugin-react-hooks emits correct types for consumers in Node16 ESM projects. ([#​34949](facebook/react#34949) by [@​karlhorky](https://github.com/karlhorky)) - Tightened the typing of `configs.flat` so the `configs` export is always defined. ([#​34950](facebook/react#34950) by [@​poteto](https://github.com/poteto)) - Fix named import runtime errors. ([#​34951](facebook/react#34951), [#​34953](facebook/react#34953) by [@​karlhorky](https://github.com/karlhorky)) ### [`v7.0.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#700) [Compare Source](facebook/react@a2329c1...4b3e662) This release slims down presets to just 2 configurations (`recommended` and `recommended-latest`), and all compiler rules are enabled by default. - **Breaking:** Removed `recommended-latest-legacy` and `flat/recommended` configs. The plugin now provides `recommended` (legacy and flat configs with all recommended rules), and `recommended-latest` (legacy and flat configs with all recommended rules plus new bleeding edge experimental compiler rules). ([@​poteto](https://github.com/poteto) in [#​34757](facebook/react#34757)) </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!242 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>
736-c41-2c1-e464fc974
added a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Jan 14, 2026
chore(deps): update eslint-plugin-react-hooks (major) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [eslint-plugin-react-hooks](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks)) | devDependencies | major | [`^6.0.0` → `^7.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-react-hooks/6.1.1/7.0.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/facebook/react) | --- ### Release Notes <details> <summary>facebook/react (eslint-plugin-react-hooks)</summary> ### [`v7.0.1`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#701) [Compare Source](facebook/react@4b3e662...408b38e) - Disallowed passing inline `useEffectEvent` values as JSX props to guard against accidental propagation. ([#​34820](facebook/react#34820) by [@​jf-eirinha](https://github.com/jf-eirinha)) - Switch to `export =` so eslint-plugin-react-hooks emits correct types for consumers in Node16 ESM projects. ([#​34949](facebook/react#34949) by [@​karlhorky](https://github.com/karlhorky)) - Tightened the typing of `configs.flat` so the `configs` export is always defined. ([#​34950](facebook/react#34950) by [@​poteto](https://github.com/poteto)) - Fix named import runtime errors. ([#​34951](facebook/react#34951), [#​34953](facebook/react#34953) by [@​karlhorky](https://github.com/karlhorky)) ### [`v7.0.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#700) [Compare Source](facebook/react@a2329c1...4b3e662) This release slims down presets to just 2 configurations (`recommended` and `recommended-latest`), and all compiler rules are enabled by default. - **Breaking:** Removed `recommended-latest-legacy` and `flat/recommended` configs. The plugin now provides `recommended` (legacy and flat configs with all recommended rules), and `recommended-latest` (legacy and flat configs with all recommended rules plus new bleeding edge experimental compiler rules). ([@​poteto](https://github.com/poteto) in [#​34757](facebook/react#34757)) </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!242 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 7.0.0:
Slim down presets to just 2 configurations:
recommended: legacy and flat config with all recommended rules, andrecommended-latest: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rulesRemoved:
recommended-latest-legacyflat/recommendedPlease see the README for new install instructions.
Stack created with Sapling. Best reviewed with ReviewStack.