Add last_updated to metadata document#262
Merged
afragen merged 3 commits intofairpm:mainfrom Oct 27, 2025
Merged
Conversation
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
Contributor
|
Needs fairpm/fair-beacon#54 and a spec update. |
afragen
approved these changes
Sep 23, 2025
Contributor
afragen
left a comment
afragen
left a comment
There was a problem hiding this comment.
This will be correct when last_updated is added to mini-fair MetaDataDocument.
afragen
changed the title
afragen
approved these changes
Sep 24, 2025
afragen
reviewed
Oct 15, 2025
Signed-off-by: Andy Fragen <andy@thefragens.com> Signed-off-by: Andy Fragen <andy@thefragens.com>
Contributor
|
@costdev Adding to 1.1 unless you think we should bump it to 1.2? |
Member
Author
|
@Ipstenu I definitely want this "Last Updated 56 years ago" issue fixed for 1.1, and it's achievable. While there's still discussion pending on the ideal location for the date, this PR and the MiniFAIR PR can resolve the issue without locking us into a specific location forever. The discussion, investigation, etc. on the ideal location should absolutely be resolved as soon as possible, and would be best done in the Protocol issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: