Added support for timeouts in messaging module#132
Added support for timeouts in messaging module#132hiranya911 merged 1 commit intofirebase:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
861b9ca to
d66b274
Compare
hiranya911
left a comment
There was a problem hiding this comment.
Thanks @carsongee. This looks great. Can you also add a test case? Something similar to: https://github.com/firebase/firebase-admin-python/blob/master/tests/test_db.py#L597
|
I'll try and get that test written tomorrow, thanks for the consideration ✨ |
0f6cf00 to
f0247c4
Compare
|
tests added |
hiranya911
left a comment
There was a problem hiding this comment.
Please fix the lint error, and then this is good to go.
tests/test_messaging.py
Outdated
| assert len(recorder) == 1 | ||
| assert recorder[0].method == 'POST' | ||
| assert recorder[0].url == self._get_url('explicit-project-id') | ||
| assert recorder[0]._extra_kwargs['timeout'] == None |
There was a problem hiding this comment.
Implement this check with is None to avoid the lint error: https://travis-ci.org/firebase/firebase-admin-python/jobs/351093644#L552
f0247c4 to
a90f4c8
Compare
This adds support for using the
httpTimeoutoption from theAppfor specifying client timeout parameters inside of the messaging module.