Add rate limiting exceptions#695
Merged
jonathanedey merged 1 commit intofirebase:masterfrom Mar 6, 2024
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
@pragatimodi Since you are assigned to #666, would you be able to check this out? |
skion
force-pushed
the
rate-limiting
branch
2 times, most recently
from
190b7c8 to
4ad0339
Compare
Contributor
Author
|
@jonathanedey I see you are mostly maintaining this repo now, is this something you could have a look at? |
lahirumaramba
approved these changes
Mar 5, 2024
pragatimodi
approved these changes
Mar 5, 2024
jonathanedey
approved these changes
Mar 5, 2024
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
There was a problem hiding this comment.
Hi @skion, This looks great. Thank you so much for your patience in getting this added!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two exception types to enable users to detect rate limited calls which were previously swallowed and converted into a generic
InvalidArgumentError, making it impossible to detect rate limiting situations and pass that information through to the end user.This is being discussed in #666.
I chose to inherit from the
ResourceExhaustedErrorbase exception, which seemed to make most sense.