Make the argument-values.json profile fixture go through profile upgrading#5796
Merged
mstange merged 1 commit intofirefox-devtools:mainfrom Jan 30, 2026
Merged
Conversation
mstange
commented
Jan 29, 2026
| const profiler = await unserializeProfileOfArbitraryFormat( | ||
| require('../fixtures/upgrades/argument-values.json') | ||
| ); | ||
| const store = storeWithProfile(profiler); |
Contributor
Author
There was a problem hiding this comment.
I should probably add a check inside storeWithProfile which throws an exception if it sees something that's not a fully-upgraded profile.
Contributor
Author
There was a problem hiding this comment.
I've updated this PR to include that change.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5796 +/- ##
==========================================
- Coverage 85.64% 85.64% -0.01%
==========================================
Files 319 319
Lines 31316 31318 +2
Branches 8630 8629 -1
==========================================
+ Hits 26821 26822 +1
- Misses 4064 4065 +1
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
approved these changes
Jan 30, 2026
| const profiler = await unserializeProfileOfArbitraryFormat( | ||
| require('../fixtures/upgrades/argument-values.json') | ||
| ); | ||
| const store = storeWithProfile(profiler); |
…ading. Otherwise we'll have to change it whenever we change the format.
mstange
force-pushed
the
argument-values-fixture-upgrading
branch
from
c51d8da to
23cab85
Compare
canova
added a commit
that referenced
this pull request
Feb 4, 2026
Changes: [Nazım Can Altınova] Make the range duration text white again (#5792) [Alex Thayer] Display traced values in Stack Chart view (#5363) [Nazım Can Altınova] Improve the JS traced arguments visualization in call node tooltips (#5795) [Markus Stange] Make the argument-values.json profile fixture go through profile upgrading (#5796) [Markus Stange] Add thread.usedInnerWindowIDs to the processed profile format (#5780) [fatadel] Fix context menu and hover preview z-index (#5797) [fatadel] add TrackPower--tooltip-power-microwatt (#5799) [Markus Stange] Two small test fixes (#5801) [fatadel] fix selected thread pid color in light mode (#5805) [Markus Stange] Some fixes to the profile merging code (#5802) [fatadel] fix disabled button color in dark mode (#5808) [fatadel] add comment for uptime label translation (#5806) [Nazım Can Altınova] Add a theme toggle to the home page and follow the system theme by default (#5800) [Nazım Can Altınova] 🔃 Sync: l10n -> main (Feb 4, 2025) (#5813) And huge thanks to our localizers: de: Ger de: Michael Köhler de: Nazım Can Altınova el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson tr: Selim Şumlu zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we'll have to change it whenever we change the format.