ignition: Remove /boot/coreos/first_boot#10
Merged
pothos merged 1 commit intoflatcar-masterfrom Mar 16, 2020
Merged
Conversation
dongsupark
reviewed
Mar 9, 2020
Whether /boot/coreos/first_boot or /boot/flatcar/first_boot is used depends on the GRUB code present in the MBR/EFI. Remove both files in the initramfs depending on whether they exist and error out if deletion fails or if none of them existed.
pothos
force-pushed
the
kai/remove-boot-coreos-first_boot
branch
from
792dd6e to
4b04822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether /boot/coreos/first_boot or /boot/flatcar/first_boot
is used depends on the GRUB code present in the MBR/EFI.
Remove both files in the initramfs depending on whether
they exist and error out if deletion fails or if none of
them existed.
Note: Create a PR for coreos-overlay after merging (and also pick that for Alpha and Edge when merged).