Add a Match section for systemd to not ignore .network files#16
Merged
sayanchowdhury merged 1 commit intoflatcar-masterfrom Jul 21, 2020
Merged
Conversation
pothos
reviewed
Jul 20, 2020
pothos
reviewed
Jul 20, 2020
Member
pothos
left a comment
pothos
left a comment
There was a problem hiding this comment.
Thanks, looks good, I think it would even make sense to add Name=* to dracut/03flatcar-network/yy-pxe.network as well – I don't know yet if it is required but the match section has nothing interface-specific and in the spirit of this patch I expect it to be made explicit, too.
systemd ignores .link and .network files if the Match section is empty Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
sayanchowdhury
force-pushed
the
sayan/upgrade-systemd-to-v245
branch
from
f71d4d2 to
bf79d0f
Compare
pothos
approved these changes
Jul 20, 2020
dongsupark
approved these changes
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Match section for systemd to not ignore
systemd 245 ignores .link and .network files if the Match section is empty. More details in the NEWS entry.
This should be merged with flatcar-archive/coreos-overlay#448
Signed-off-by: Sayan Chowdhury sayan.chowdhury2012@gmail.com
How to use
Testing done
Without these options, the SSH to the machine was broken, and no packets were received by the machine. This fixes the issue.