ignition-generator: make the hostname units optional#23
Merged
margamanterola merged 1 commit intoflatcar-masterfrom Apr 8, 2021
Merged
ignition-generator: make the hostname units optional#23margamanterola merged 1 commit intoflatcar-masterfrom
margamanterola merged 1 commit intoflatcar-masterfrom
Conversation
Having the hostname units as required by the initrd.target meant that if the unit failed (for example because the network was or the metadata service were down), the machine wouldn't start. By making it a "wants" rather than a "requires" we allow this unit to fail without disrupting the whole boot.
pothos
approved these changes
Apr 7, 2021
Contributor
Author
|
CI passed, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the hostname units as required by the initrd.target meant that if
the unit failed (for example because the network was or the metadata
service were down), the machine wouldn't start. By making it a "wants"
rather than a "requires" we allow this unit to fail without disrupting
the whole boot.
Testing done
I ran CI with this change and it succeeded.