dracut/99emergency-timeout/timeout.sh: fix heredoc leak into arguments#33
Merged
pothos merged 2 commits intoflatcar-masterfrom Jan 12, 2022
Merged
dracut/99emergency-timeout/timeout.sh: fix heredoc leak into arguments#33pothos merged 2 commits intoflatcar-masterfrom
pothos merged 2 commits intoflatcar-masterfrom
Conversation
The content that was supposed to be in the heredoc got interpreted as parameters for "cat", causing it to fail. Move the separator dahes into the next line to make sure it gets treated as heredoc content.
The old CoreOS online validator does not have a new Flatcar home yet. Use the repo link for the binary of it instead.
krnowak
approved these changes
Jan 12, 2022
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jan 12, 2022
This pulls in flatcar/bootengine#33 to fix the cat command invocation.
1 task
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jan 12, 2022
This pulls in flatcar/bootengine#33 to fix the cat command invocation.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jan 12, 2022
This pulls in flatcar/bootengine#33 to fix the cat command invocation.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 26, 2022
This pulls in flatcar/bootengine#33 to fix the error message printing when Ignition fails.
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 13, 2023
This pulls in flatcar/bootengine#33 to fix the error message printing when Ignition fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dracut/99emergency-timeout/timeout.sh: fix heredoc leak into arguments
The content that was supposed to be in the heredoc got interpreted as
parameters for "cat", causing it to fail.
Move the separator dahes into the next line to make sure it gets
treated as heredoc content.
dracut/99emergency-timeout/timeout.sh: replace old CoreOS link
The old CoreOS online validator does not have a new Flatcar home yet.
Use the repo link for the binary of it instead.
How to use
Create coreos-overlay PR to update the commit reference and add the changelog there
Testing done
None, just manual execution of the moved line
changelog/directory (user-facing change, bug fix, security fix, update)↑ Not done here, should be done in the coreos-overlay PR that pulls it in