Skip to content

Comments

ignition-kargs-helper: Ensure that grub.cfg exists before reading#47

Merged
pothos merged 1 commit intoflatcar-masterfrom
kai/kargs-nonexisting-grubcfg
Jul 14, 2022
Merged

ignition-kargs-helper: Ensure that grub.cfg exists before reading#47
pothos merged 1 commit intoflatcar-masterfrom
kai/kargs-nonexisting-grubcfg

Conversation

@pothos
Copy link
Member

@pothos pothos commented Jul 13, 2022

The kola kargs test fails for the generic image when it's not mangled
(which is the kola term for setting the console option by creating the
grub.cfg file) because the kargs helper didn't handle the case where
the file doesn't exist which is normal for the generic image.
Create the grub.cfg file if it doesn't exist before trying to read from
it.

How to use

We can backport it on the bootengine backport branches

Testing done

build

  • tested manually setting --qemu-skip-mangle as kola flag
  • and using the qemu script with this test Ignition config:
{
  "ignition": {
    "version": "3.3.0"
  },
  "kernelArguments": {
    "shouldExist": ["flatcar.autologin"]
  }
}
  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
    ↑ in coreos-overlay

pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Jul 13, 2022
This pulls in
flatcar/bootengine#47
which creates the grub.cfg file if it does not exist when the Ignition
kargs directive is used, preventing an error when it tried to read the
current settings from it.
The kola kargs test fails for the generic image when it's not mangled
(which is the kola term for setting the console option by creating the
grub.cfg file) because the kargs helper didn't handle the case where
the file doesn't exist which is normal for the generic image.
Create the grub.cfg file if it doesn't exist before trying to read from
it.
@pothos pothos force-pushed the kai/kargs-nonexisting-grubcfg branch from 411ae57 to 914f9d3 Compare July 13, 2022 15:12
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Jul 13, 2022
This pulls in
flatcar/bootengine#47
which creates the grub.cfg file if it does not exist when the Ignition
kargs directive is used, preventing an error when it tried to read the
current settings from it.
@pothos pothos merged commit 95bb406 into flatcar-master Jul 14, 2022
@pothos pothos deleted the kai/kargs-nonexisting-grubcfg branch July 14, 2022 08:29
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Jul 14, 2022
This pulls in
flatcar/bootengine#47
which creates the grub.cfg file if it does not exist when the Ignition
kargs directive is used, preventing an error when it tried to read the
current settings from it.
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Jul 14, 2022
This pulls in
flatcar/bootengine#47
which creates the grub.cfg file if it does not exist when the Ignition
kargs directive is used, preventing an error when it tried to read the
current settings from it.
pothos added a commit that referenced this pull request Jul 14, 2022
ignition-kargs-helper: Ensure that grub.cfg exists before reading
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Jul 14, 2022
This pulls in
flatcar/bootengine#47
which creates the grub.cfg file if it does not exist when the Ignition
kargs directive is used, preventing an error when it tried to read the
current settings from it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants