ignition: Create /run/ignition.env on every boot#86
Merged
pothos merged 1 commit intoflatcar-masterfrom Feb 12, 2024
Merged
Conversation
The rework of the generator moved the creation of the /run/ignition.env file to the setup script but that was only running on the first boot while the /run/ignition.env file should exist on every boot. Move the creation to its own "ignition-setup-pre" service that always runs.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the previous rework that only created /run/ignition.env on the first boot while we rely on it to run cloud-init on every boot when no Ignition config was provided.
2 tasks
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the previous rework that only created /run/ignition.env on the first boot while we rely on it to run cloud-init on every boot when no Ignition config was provided.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the previous rework that only created /run/ignition.env on the first boot while we rely on it to run cloud-init on every boot when no Ignition config was provided.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/bootengine#86 to fix the previous rework that only created /run/ignition.env on the first boot while we rely on it to run cloud-init on every boot when no Ignition config was provided.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rework of the generator moved the creation of the /run/ignition.env file to the setup script but that was only running on the first boot while the /run/ignition.env file should exist on every boot. Move the creation to its own "ignition-setup-pre" service that always runs.
How to use
Backport to flatcar-3874
Testing done
Checked that
oem-cloudinit.servicewon't fail on second boot and that/run/ignition.envexists.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.