network: Restore KeepConfiguration=dhcp-on-stop#10
Merged
pothos merged 1 commit intoflatcar-masterfrom Nov 12, 2020
Merged
Conversation
The default behavior in systemd-networkd was changed in v244 from keeping the IP addresses and routes on service stop to deconfiguring them: systemd/systemd@8006035 Deconfiguring means that on system shutdown the DHCP address is properly released but also has the side effect that orphaned processes not part of a systemd unit don't have network connectivity when they get the broadcasted SIGTERM. Restore the previous behavior and hope that DHCP servers recognize the system again on reboot and hand out the same address don't have to rely on the address release (which, anyway, is not sent for a crashing system either). Fixes flatcar/Flatcar#213
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 10, 2020
Pulls in flatcar/coreos-cloudinit#10 flatcar/init#30 to restore the systemd-networkd 243 behavior with KeepConfiguration=dhcp-on-stop to prevent the network from going down before the SIGTERM is broadcasted to orphaned processes not part of a systemd unit.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 12, 2020
Pulls in flatcar/coreos-cloudinit#10 flatcar/init#30 to restore the systemd-networkd 243 behavior with KeepConfiguration=dhcp-on-stop to prevent the network from going down before the SIGTERM is broadcasted to orphaned processes not part of a systemd unit.
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 13, 2020
Pulls in flatcar/coreos-cloudinit#10 flatcar/init#30 to restore the systemd-networkd 243 behavior with KeepConfiguration=dhcp-on-stop to prevent the network from going down before the SIGTERM is broadcasted to orphaned processes not part of a systemd unit.
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 13, 2020
Pulls in flatcar/coreos-cloudinit#10 flatcar/init#30 to restore the systemd-networkd 243 behavior with KeepConfiguration=dhcp-on-stop to prevent the network from going down before the SIGTERM is broadcasted to orphaned processes not part of a systemd unit.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 3, 2020
Pulls in flatcar/coreos-cloudinit#10 flatcar/init#30 to restore the systemd-networkd 243 behavior with KeepConfiguration=dhcp-on-stop to prevent the network from going down before the SIGTERM is broadcasted to orphaned processes not part of a systemd unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior in systemd-networkd was changed in v244 from
keeping the IP addresses and routes on service stop to deconfiguring
them:
systemd/systemd@8006035
Deconfiguring means that on system shutdown the DHCP address is
properly released but also has the side effect that orphaned processes
not part of a systemd unit don't have network connectivity when they
get the broadcasted SIGTERM.
Restore the previous behavior and hope that DHCP servers recognize
the system again on reboot and hand out the same address don't have to
rely on the address release (which, anyway, is not sent for a crashing
system either).
Fixes flatcar/Flatcar#213
How to use
Configure, e.g., a VMware instance with the guestinfo network variables to use DHCP.
Then check
to report the interface as configured with an IP address.
Testing done
Ran kola tests on all platforms.