systemd/system/sshkeys: Make execution more robust#112
Merged
pothos merged 1 commit intoflatcar-masterfrom Nov 17, 2023
Merged
Conversation
tormath1
reviewed
Nov 17, 2023
The service failed when the unit to start was masked. Since it involves networking, the service can fail and if it does we should restart. It also seems that the service relied on update-ssh-keys-after-ignition.service to run update-ssh-keys once to create the subfolder and could possibly race with it. Prevent execution when it has no chance to succeed because the unit to start is masked but in all other cases try to restart on failure. Also order behind update-ssh-keys-after-ignition.service.
tormath1
approved these changes
Nov 17, 2023
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Nov 17, 2023
This pulls in flatcar/init#112 to only run coreos-metadata-sshkeys@core.service when not masked and also retry on failure.
2 tasks
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Nov 17, 2023
This pulls in flatcar/init#112 to only run coreos-metadata-sshkeys@core.service when not masked and also retry on failure.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Nov 17, 2023
This pulls in flatcar/init#112 to only run coreos-metadata-sshkeys@core.service when not masked and also retry on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service failed when the unit to start was masked. Since it involves
networking, the service can fail and if it does we should restart. It
also seems that the service relied on
update-ssh-keys-after-ignition.service to run update-ssh-keys once to
create the subfolder and could possibly race with it.
Prevent execution when it has no chance to succeed because the unit to
start is masked but in all other cases try to restart on failure. Also
order behind update-ssh-keys-after-ignition.service.
How to use
Backport
Testing done
with
and verifying that the service does not run when the unit to start is masked.
@tormath1 also checked that the spurious failure experienced when
update-ssh-keys-after-ignition.serviceis slower thansshkeys.servicedidn't occur again.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.