sshkeys: enable SSH keys injection from Scaleway IMDS#135
Merged
tormath1 merged 1 commit intoflatcar-masterfrom Sep 16, 2025
Merged
sshkeys: enable SSH keys injection from Scaleway IMDS#135tormath1 merged 1 commit intoflatcar-masterfrom
tormath1 merged 1 commit intoflatcar-masterfrom
Conversation
tormath1
force-pushed
the
tormath1/scaleway
branch
from
aaf811d to
3e7b365
Compare
krnowak
approved these changes
Sep 16, 2025
| ConditionKernelCommandLine=|ignition.platform.id=proxmoxve | ||
| ConditionKernelCommandLine=|flatcar.oem.id=proxmoxve | ||
|
|
||
| ConditionKernelCommandLine=|flatcar.oem.id=scaleway |
Member
There was a problem hiding this comment.
It certainly is an odd one out here, without the ignition.platform.id variant. I suppose it is on purpose, right?
Contributor
Author
There was a problem hiding this comment.
We initially added this ignition.platform.id to be closer from the upstream but I honestly doubt we will change flatcar.oem.id -> ignition.platform.id one day.
But I'll add the ignition.platform.id to be consistent with the other entries (and we never know!)
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/scaleway
branch
from
3e7b365 to
255d0ff
Compare
Contributor
Author
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we enable SSH keys injection from Scaleway IMDS. In case one wants to add SSH keys to the instance without using Ignition.
I've tested it and this has been tested by the user reporting the issue as well.
This has to be backported on some maintainance branches for
init.