scripts/motdgen: Add OEM information to motd output#34
Merged
pothos merged 2 commits intoflatcar-masterfrom Feb 3, 2021
Merged
scripts/motdgen: Add OEM information to motd output#34pothos merged 2 commits intoflatcar-masterfrom
pothos merged 2 commits intoflatcar-masterfrom
Conversation
Contributor
margamanterola
left a comment
margamanterola
left a comment
There was a problem hiding this comment.
Thanks for working on this. Unfortunately, I'm not sure this ends up creating the string we want :(
pothos
force-pushed
the
kai/add-oem-to-motd
branch
from
6df6e44 to
f0ace3a
Compare
The message-of-the-day login greeter shows basic information about the OS but so far did not give a hint whether an OEM variant is used and which (e.g., "Flatcar Container Linux by Kinvolk stable (2605.12.0)"). Append the OEM name to it, like "for Amazon EC2".
pothos
force-pushed
the
kai/add-oem-to-motd
branch
from
f0ace3a to
a628bd7
Compare
In case another part has brackets, it looks strange to have two pairs of them in one line. Since they are not really needed in the relation of channels vs version, leave them out.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 3, 2021
This pulls in flatcar/init#34
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 3, 2021
Using the change in flatcar/init#34 we can show the OEM on the motd, and by including "Pro" in the OEM name we can also show whether it is a Pro image or not. Later this may be revisited if the /usr/../os-release file is the place for it.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 3, 2021
This pulls in flatcar/init#34
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 3, 2021
Using the change in flatcar/init#34 we can show the OEM on the motd, and by including "Pro" in the OEM name we can also show whether it is a Pro image or not. Later this may be revisited if the /usr/../os-release file is the place for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message-of-the-day login greeter shows basic information about the
OS but so far did not give a hint whether an OEM variant is used and
which (e.g., "Flatcar Container Linux by Kinvolk stable (2605.12.0)").
Append the OEM name to it, like "for Amazon EC2".
How to use
Build an OEM image and see that the name is shown at login
Testing done
Only manual execution of the changed script lines