bin/flatcar-install: add parameters to make wget more resilient#35
Merged
pothos merged 1 commit intoflatcar-masterfrom Feb 12, 2021
Merged
bin/flatcar-install: add parameters to make wget more resilient#35pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
When the network has temporary issues it can happen that wget fails to establish a connection or complete the transfer, or worse, get stuck in a TCP connection which is not moving forward. Add timeout and retry parameters to prevent unnecessary failure if a retry fixes the problem and also to prevent the connection from getting stuck.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 12, 2021
This pulls in flatcar/init#35 to add parameters for wget in bin/flatcar-install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the network has temporary issues it can happen that wget fails to
establish a connection or complete the transfer, or worse, get stuck
in a TCP connection which is not moving forward.
Add timeout and retry parameters to prevent unnecessary failure if a
retry fixes the problem and also to prevent the connection from getting
stuck.
How to use
Use
flatcar-install -sfrom a PXE-booted Flatcar image to install to disk, check that it works and is even robust against the network dropping packets for the specified timeout of 20 seconds.Testing done
Ran the
wgetcommand line on a test file while breaking my local connection. Also tested thatsudo flatcar-install -sstill works as expected.