flatcar-install uses lbzip2 if present, falls back on bzip2 if not#46
Merged
pothos merged 1 commit intoflatcar:flatcar-masterfrom Aug 26, 2021
aniruddha2000:aniruddha2000/use-lbzip2
Merged
flatcar-install uses lbzip2 if present, falls back on bzip2 if not#46pothos merged 1 commit intoflatcar:flatcar-masterfrom aniruddha2000:aniruddha2000/use-lbzip2
pothos merged 1 commit intoflatcar:flatcar-masterfrom
aniruddha2000:aniruddha2000/use-lbzip2
Conversation
pothos
reviewed
Aug 26, 2021
Member
pothos
left a comment
There was a problem hiding this comment.
Looks good, can you squash the commits (and use the message from the second)?
Contributor
Author
|
@pothos yup sure! |
pothos
approved these changes
Aug 26, 2021
Member
pothos
left a comment
There was a problem hiding this comment.
Tested with sudo ./flatcar-install -s -o "" -C stable on a QEMU VM and it uses lbzip2 when available and otherwise bzip2, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check lbzip2 and set it in global variable
Check if lbzip2 is there or not. If yes then set it to a global variable called BZIP_UTIL or if not then set bzip2 to the global variable and use it for further work.
Testing done
Added lbzip2 to the custom Flatcar image and checked with
flatcar-installscriptflatcar-install -d /dev/vdb(with and without the-fflag).Writing flatcar_production_qemu_image.img.bz2... Success! Flatcar Container Linux (from flatcar_production_qemu_image.img.bz2) is installed on /dev/vdb