networkd: do not use DHCP for bridge devices#56
Merged
pothos merged 2 commits intoflatcar-masterfrom Dec 20, 2021
Merged
Conversation
Member
|
Would this change mean that #55 is not necessary and other network files excluding specific bridge devices could also be dropped? |
Member
Author
Maybe yes but this is also something that could be reverted if it makes problems, I would keep the specific rules we have for the mean time. |
4239c14 to
6c21449
Compare
The Calico vxlan interface was getting the default networkd configuration applied which tries to attach an IP address through DHCP. This meant that the interface was stuck in this "configuring" state by networkd and this is also a potential source of disruption as reported in similar cases. Set the vxlan.calico interface to be excluded from networkd (unmanaged) because it is set up manually by Calico and not through DHCP.
We are always lagging behind with which interface names are used by CNIs and have to be set Unmanaged so that we don't use DHCP for them. Go the other way round and exclude special devices which won't use DHCP upfront so that we don't even try configuring them this way. Bridges normally don't get their IP address assinged via DHCP and if someone wants that, they are free to ship their own networkd unit. Same for tunnel devices and similar. If this causes problems, we can revert this because we still have the explicit rules but eventually this should allow us to retire some of our rules that match by interface name.
6c21449 to
e47126b
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 16, 2021
This pulls in flatcar/init#56 to find a generic way of preventing conflicts with CNI interfaces that shouldn't use DHCP and were matched by name to be set Unmanaged.
1 task
krnowak
approved these changes
Dec 16, 2021
Member
krnowak
left a comment
There was a problem hiding this comment.
Looks good. I suppose it will be release-notes-worthy change.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 16, 2021
This pulls in flatcar/init#56 to find a generic way of preventing conflicts with CNI interfaces that shouldn't use DHCP and were matched by name to be set Unmanaged.
Member
Author
Right, added it in the coreos-overlay PR and can make it even more verbose if wanted |
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 16, 2021
This pulls in flatcar/init#56 to find a generic way of preventing conflicts with CNI interfaces that shouldn't use DHCP and were matched by name to be set Unmanaged.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 20, 2021
This pulls in flatcar/init#56 to find a generic way of preventing conflicts with CNI interfaces that shouldn't use DHCP and were matched by name to be set Unmanaged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change:
A drive-by fix which is still relevant in case we have revert the main change:
How to use
Testing done