systemd: add helper service to start sysext services#65
Merged
pothos merged 1 commit intoflatcar-masterfrom Mar 17, 2022
Merged
systemd: add helper service to start sysext services#65pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 15, 2022
1 task
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 16, 2022
jepio
reviewed
Mar 16, 2022
pothos
force-pushed
the
kai/ensure-sysext
branch
from
e693b2a to
2c57c47
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 16, 2022
As systemd-sysext images are not really meant for system services (that is the role of portable services) the services that they define don't get started even if they include the symlinks to do so. Add a helper service that starts the new services by retriggering the socket, timers and multi-user targets as these are the targets a user would normally use to enable units. We can add more as needed.
pothos
force-pushed
the
kai/ensure-sysext
branch
from
2c57c47 to
96bc0b3
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 16, 2022
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 17, 2022
krnowak
approved these changes
Mar 17, 2022
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 17, 2022
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As systemd-sysext images are not really meant for system services
(that is the role of portable services) the services that they define
don't get started even if they include the symlinks to do so.
Add a helper service that starts the new services by retriggering the
socket, timers and multi-user targets as these are the targets a user
would normally use to enable units. We can add more as needed.
How to use
systemctl start systemd-sysextor booting when this service is enabled will now start the services defined in the sysext image that is loaded (given they use the multi-user or sockets targets)Testing done
the above with a converted torcx image (plus the regular kola build tests as linked in the coreos-overlay PR)
changelog/directory (user-facing change, bug fix, security fix, update)↑ in coreos-overlay