Added option to specify port1 and port2#81
Merged
krnowak merged 7 commits intoflatcar:flatcar-masterfrom Oct 4, 2022
Merged
Conversation
krnowak
requested changes
Aug 25, 2022
Member
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
Thanks for the PR! Found some small issues.
pothos
reviewed
Aug 25, 2022
Cool Co-authored-by: Krzesimir Nowak <qdlacz@gmail.com>
Co-authored-by: Krzesimir Nowak <qdlacz@gmail.com>
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Co-authored-by: Krzesimir Nowak <qdlacz@gmail.com>
Contributor
Author
|
Suggested changes are committed :) |
krnowak
approved these changes
Aug 30, 2022
Member
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
Two nitpicks, otherwise looks good.
Co-authored-by: Krzesimir Nowak <qdlacz@gmail.com>
Co-authored-by: Krzesimir Nowak <qdlacz@gmail.com>
Contributor
Author
Fixed - thank you |
krnowak
approved these changes
Oct 4, 2022
Member
|
Thanks again for the PR! |
Member
|
PR in coreos-overlay to pull these changes for the next alpha: flatcar-archive/coreos-overlay#2198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to specify port1 and port2
Added option to specify port1 and port2
We are getting conflicts with services that are already listening on these ports
new params
" -L, --listen-port-1 <LISTEN_PORT_1> Overwrites standard listen port 9090"
" -M, --listen-port-2 <LISTEN_PORT_2> Overwrites standard listen port 9091"
How to use
Test by using
Testing done
Tested in flatcar 3227.2.0