platform: enable enforcing mode SELinux earlier#252
Merged
tormath1 merged 3 commits intoflatcar-masterfrom Nov 18, 2021
Merged
Conversation
this method can be removed in order to prepare new SELinux implementation logic. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
with this Container Linux Configuration - we allow the system to set SELinux in enforcing mode as soon as possible in the boot process. It relies on the existing Kola flag: `NoEnableSelinux` - current logic will be preserved. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
pothos
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we enable SELinux in enforcing mode earlier in the boot. Previously, it was done once the instance booted by running
sudo setenforce 1.By enabling and running all the tests with
enforcingmode set as soon as possible during the boot, we'll be able to catch early denial from SElinux (like this one: flatcar-archive/coreos-overlay#1426) which can prevent Flatcar to behave correctly.How to use
Testing done
with the patch proposed in flatcar-archive/coreos-overlay#1426; it works fine: