Skip to content

Comments

esx: support initramfs network configuration#329

Merged
tormath1 merged 3 commits intoflatcar-masterfrom
tormath1/kargs
Nov 17, 2022
Merged

esx: support initramfs network configuration#329
tormath1 merged 3 commits intoflatcar-masterfrom
tormath1/kargs

Conversation

@tormath1
Copy link
Contributor

@tormath1 tormath1 commented Apr 28, 2022 •
edited
Loading

In this PR, we add the ip kernel argument following this pattern1:

ip=<client-IP>:[<peer>]:<gateway-IP>:<netmask>:<client_hostname>:<interface>:{none|off|dhcp|on|any|dhcp6|auto6|ibft}[:[<dns1>][:<dns2>]]

and we remove esx from excluded platforms for network reasons.

Related to: flatcar/Flatcar#717

I'm not sure it takes a changelog entry

EDIT: don't merge this before getting the feature in stable - otherwise we'll prevent the impacted tests to run

Footnotes

  1. https://mirrors.edge.kernel.org/pub/linux/utils/boot/dracut/dracut.html#_network ↩

@tormath1 tormath1 self-assigned this Apr 28, 2022
This was referenced Apr 28, 2022
Merged
Merged
@tormath1 tormath1 force-pushed the tormath1/kargs branch 2 times, most recently from e175cbb to 61264e5 Compare May 11, 2022 13:00
pothos
pothos reviewed May 12, 2022
View reviewed changes
@tormath1 tormath1 marked this pull request as ready for review May 12, 2022 16:04
@tormath1 tormath1 requested a review from a team May 12, 2022 16:04
krnowak
krnowak approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't get the request to not merge it until a feature hits stable. Which feature? Some dracut version?

@tormath1
Copy link
Contributor Author

tormath1 commented May 12, 2022

Looks good, but I don't get the request to not merge it until a feature hits stable. Which feature? Some dracut version?

Sorry for not being clear :D I'm referring to this feature: flatcar/bootengine#44. Setting a new guestinfo variable to an instance is harmless but if we merge right now this PR, we'll get failures on tests modified in this commit: be94854

@krnowak
Copy link
Member

krnowak commented May 12, 2022

Looks good, but I don't get the request to not merge it until a feature hits stable. Which feature? Some dracut version?

Sorry for not being clear :D I'm referring to this feature: flatcar-linux/bootengine#44. Setting a new guestinfo variable to an instance is harmless but if we merge right now this PR, we'll get failures on tests modified in this commit: be94854

Cool, thanks for making it clear. :)

So, uh, is this PR going to wait for a month (until current alpha becomes stable) or the plan is to cherry-pick the bootengine changes to stable?

@pothos
Copy link
Member

pothos commented May 13, 2022

We could use the min version flag but that means we stop running tests on all platforms for Stable…

@tormath1
api/esx: add network configuration in initrd
bdd61a9 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
pothos
pothos reviewed Nov 17, 2022
View reviewed changes
pothos
pothos reviewed Nov 17, 2022
View reviewed changes
@pothos
Copy link
Member

pothos commented Nov 17, 2022

We need MinVersion: semver.Version{Major: abcd}, for the tests to be skipped on LTS.

@tormath1
Copy link
Contributor Author

tormath1 commented Nov 17, 2022 •
edited
Loading

We need MinVersion: semver.Version{Major: abcd}, for the tests to be skipped on LTS.

See this answer: #329 (comment) I'd like to avoid skipping kubeadm tests on LTS for example :D

pothos
pothos reviewed Nov 17, 2022
View reviewed changes
pothos
pothos reviewed Nov 17, 2022
View reviewed changes
@tormath1
kola/harness: add the ability to skip a test
01ad8c9 
Based on the version, arch, platform and channel - we can now define
custom logic for skipping a test.

It's useful for changes that are not present on LTS for
example.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
pothos
pothos reviewed Nov 17, 2022
View reviewed changes
pothos
pothos reviewed Nov 17, 2022
View reviewed changes
@tormath1
tests: remove ESX platform from excluded platforms
0cdc4a9 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
pothos
pothos approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up again! The solution we found now will be useful for similar cases :)

@tormath1 tormath1 merged commit 2dfd18b into flatcar-master Nov 17, 2022
@tormath1 tormath1 deleted the tormath1/kargs branch November 17, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krnowak krnowak krnowak approved these changes

@pothos pothos pothos approved these changes

Assignees

@tormath1 tormath1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tormath1 @krnowak @pothos