kola/tests: test resolv.conf symlink more thoroughly#346
Merged
jepio merged 1 commit intoflatcar-masterfrom Jul 26, 2022
Merged
kola/tests: test resolv.conf symlink more thoroughly#346jepio merged 1 commit intoflatcar-masterfrom
jepio merged 1 commit intoflatcar-masterfrom
Conversation
jepio
force-pushed
the
jepio/resolv-conf-symlink-test
branch
from
bb68da8 to
a8e9985
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kola/tests: test resolv.conf symlink more thoroughly
Extend TestSymlinkResolvConf to actually read the symlink and compare to the expected value.
How to use
./bin/kola run cl.basicTesting done
Current nightly run (fails correctly): http://jenkins.infra.kinvolk.io:8080/job/os/job/kola/job/qemu/850/console
Branch with fix (succeeds): http://jenkins.infra.kinvolk.io:8080/job/os/job/kola/job/qemu/851/console
changelog/directory (user-facing change, bug fix, security fix, update)