test/network: add vmware to wireguard test#361
Merged
tormath1 merged 2 commits intoflatcar-masterfrom Aug 31, 2022
Merged
Conversation
tormath1
force-pushed
the
tormath1/wg-vmware
branch
from
9fe1521 to
216c7f2
Compare
1 task
tormath1
force-pushed
the
tormath1/wg-vmware
branch
3 times, most recently
from
e9b9b09 to
56db50b
Compare
2 tasks
krnowak
reviewed
Aug 31, 2022
Member
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
So I can understand why you changed 0.0.0.0 to 192.168.0.0, but why changing 10.100.0.2 to 172.16.0.2?
Contributor
Author
Correct, I initially changed from |
tormath1
force-pushed
the
tormath1/wg-vmware
branch
from
56db50b to
f0e1e79
Compare
krnowak
approved these changes
Aug 31, 2022
tormath1
force-pushed
the
tormath1/wg-vmware
branch
from
f0e1e79 to
e795ddf
Compare
On VMWare, the 0.0.0.0/0 seems to be an issue (while it's not on qemu setup). Changing this IP range to a private one (192.168.0.0/24) avoids to create the route that redirects all traffic from 0.0.0.0/0 to the wireguard setup.
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/wg-vmware
branch
from
e795ddf to
9bc62dd
Compare
Contributor
Author
|
commit reworded and test just ran on VMWare: http://jenkins.infra.kinvolk.io:8080/job/os/job/kola/job/vmware-esx/1039/tapResults/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com
It has been raised on Matrix that wireguard does not seem working on VMWare.