Conversation
Go 1.18 is already EOL, so no security update at all. Since upstream docker projects already have Go 1.19, Flatcar should also have that. See also https://github.com/moby/moby/blob/5d6db842238e3c4f5f9fb9ad70ea46b35227d084/Dockerfile#L6. (cherry picked from commit 93a8983) Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com> Fixes: flatcar/Flatcar#1203
dongsupark
left a comment
dongsupark
left a comment
There was a problem hiding this comment.
Thanks.
Looks good if CI passed.
Please add changelog as well.
caused by building with Go <1.19. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
Added a changelog and validated that:
|
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6467503046 |
|
@dongsupark: LTS will also need this soon? |
|
|
||
| COREOS_GO_PACKAGE="${EGO_PN}" | ||
| COREOS_GO_VERSION="go1.18" | ||
| COREOS_GO_VERSION="go1.19" |
There was a problem hiding this comment.
A fat comment here to always align this with the upstream build system would be nice
There was a problem hiding this comment.
E.g. point to https://github.com/docker/cli/blob/master/Dockerfile#L4
There was a problem hiding this comment.
No, LTS-2023 (flatcar-3510) still has Docker 20.10.23, which is still based on Go 1.18. |
Will LTS stay on docker 20.10.23 forever? |
Usually yes, we try to not touch LTS, unless there is a serious need for another version update in LTS, like a serious bug fix. |
3 participants
Build docker with go 1.19
Docker 20.10.24 expects to be built with go 1.19 and if it isn't certain unix level functionality is broken. We already bumped to building with go 1.19 for alpha-3619.0.0, so this change it present in beta/alpha/main.
Fixes a regression in stable flatcar/Flatcar#1203.
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.