build_library: support multi-arch in generate_au_zip#141
Merged
dongsupark merged 3 commits intomainfrom Aug 16, 2021
Merged
Conversation
2 tasks
Replace black list with deny list, white list with allow list.
dongsupark
force-pushed
the
dongsu/generate-au-multi-arch
branch
from
8669bba to
0175c1a
Compare
pothos
reviewed
Aug 13, 2021
pothos
approved these changes
Aug 13, 2021
To be able to support arm64 native SDK without cross builds, we should make generate_au_zip support both architectures, amd64 and arm64. Without doing that, `build_image` fails with `ERROR : Required WHITE_LIST items ld-linux-x86-64.so.2 not found!!!`, because the script recognizes only amd64 libs in WHITE_LIST. We should first determine the architecture in build_image, before running generate_au_zip, and pass the architecture, either amd64 or arm64. Also add allow_list and ld_linux parameters to necessary functions.
dongsupark
force-pushed
the
dongsu/generate-au-multi-arch
branch
from
0175c1a to
34cb6d3
Compare
Member
Author
|
CI passed |
krnowak
reviewed
Aug 13, 2021
Member
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
I only spotted some docstring issues.
Fix several docstring issues, so that the docstrings could match with the actual code.
krnowak
approved these changes
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to support arm64 native SDK without cross builds, we should make
generate_au_zipsupport both architectures, amd64 and arm64.Without doing that,
build_imagefails withERROR : Required WHITE_LIST items ld-linux-x86-64.so.2 not found!!!, because the script recognizes only amd64 libs in WHITE_LIST.We should first determine the architecture in build_image, before running
generate_au_zip, and pass the architecture, either amd64 or arm64.Also add
allow_listandld_linuxparameters to necessary functions.Replace
black listwithdeny list,white listwithallow list.How to use
Testing done
CI passed: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3281/cldsv