Conversation
pothos
reviewed
Nov 30, 2023
sdk_container/src/third_party/coreos-overlay/net-misc/openssh/openssh-9.5_p1-r1.ebuild
Outdated
Show resolved
Hide resolved
pothos
reviewed
Nov 30, 2023
sdk_container/src/third_party/coreos-overlay/net-misc/openssh/openssh-9.5_p1-r1.ebuild
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Looks better but now getting: |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/7061211572 |
pothos
approved these changes
Nov 30, 2023
Member
|
A backport to Beta would be good |
38b7660 to
dcff114
Compare
Contributor
Author
This line was not displayed on the first run of the unit, so it works correctly now - added a |
dcff114 to
ec0ff58
Compare
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Otherwise it gets restarted a few times, which displays this line in the logs: ``` Nov 30 13:28:41.819250 enable-oslogin[1232]: /etc/pam.d/sshd already exists. Not enabling OS Login ``` Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
ec0ff58 to
31f4f31
Compare
Contributor
Author
|
backported to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in logs:
The check:
scripts/sdk_container/src/third_party/coreos-overlay/coreos-base/oem-gce/files/bin/enable-oslogin
Lines 21 to 23 in 0d6e3aa
/:Testing done
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.