Skip to content

Comments

update_chroot: introduce '--setuponly' flag#178

Merged
jepio merged 1 commit intomainfrom
jepio/update-chroot-setuponly
Oct 26, 2021
Merged

update_chroot: introduce '--setuponly' flag#178
jepio merged 1 commit intomainfrom
jepio/update-chroot-setuponly

Conversation

@jepio
Copy link
Member

@jepio jepio commented Oct 25, 2021

add setuponly mode to update_chroot

update_chroot is called at the beginning of all of our jobs, but not all of them need an updated chroot. sdk and toolchains jobs use catalyst, and run in a nested chroot from a fresh extracted tarball. It can take even an hour to update the chroot. Use the --setuponly flag to only configure portage and repos.

Testing done

Started two builds for comparison.

CI with this branch:
http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3949/
CI without this branch:
http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3950/

Currently the os/sdk and os/toolchains job perform a chroot update whose
results are immediately discarded because the rest of the build uses a fresh
chroot and catalyst. Towards the end of a release period this can extend the
build time by about an hour (longer if rust is involved).

Introduce a `--setuponly` flag that bails after the chroot configuration, and
the skips chroot update.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio jepio requested a review from a team October 25, 2021 14:55
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but may be worth waiting for the test run even without an interesting test scenario.

@jepio
Copy link
Member Author

jepio commented Oct 26, 2021

CI passed with just a test-flake (reran). Merging.

@jepio jepio merged commit 50ed7f3 into main Oct 26, 2021
@jepio jepio deleted the jepio/update-chroot-setuponly branch October 26, 2021 11:53
t-lo pushed a commit that referenced this pull request Apr 17, 2023
sys-devel/gettext: sync with gentoo upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants