Merged
Conversation
apricote
commented
Apr 11, 2024
sdk_container/src/third_party/coreos-overlay/coreos-base/oem-hetzner/oem-hetzner-0.ebuild
Show resolved
Hide resolved
This was referenced Apr 11, 2024
tormath1
reviewed
Apr 11, 2024
...container/src/third_party/coreos-overlay/coreos-base/afterburn/files/coreos-metadata.service
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/coreos-base/oem-hetzner/oem-hetzner-0.ebuild
Show resolved
Hide resolved
pothos
reviewed
Apr 12, 2024
Contributor
Author
|
@tormath1 built a preview image for this PR (9a4705a). It is available here for download: https://bincache.flatcar-linux.net/images/amd64/9999.0.0+hetzner/ I updated my Packer documentation to use this image instead of using a locally built one. New docs + Packer templates are available on a new branch: https://github.com/apricote/flatcar-packer-hcloud/tree/oem-image-prebuilt |
tormath1
reviewed
Apr 16, 2024
Contributor
tormath1
left a comment
There was a problem hiding this comment.
It looks good, thanks a lot! Feel free to add a changelog entry in the changes folder: https://github.com/flatcar/scripts/tree/main/changelog/changes
...ner/src/third_party/coreos-overlay/coreos-base/common-oem-files/common-oem-files-0-r6.ebuild
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/coreos-base/coreos-init/coreos-init-9999.ebuild
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild
Show resolved
Hide resolved
tormath1
reviewed
Apr 16, 2024
Contributor
Author
|
tormath1
approved these changes
Apr 17, 2024
Contributor
|
Cherry-picked to:
|
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8722688433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide Hetzner OEM images
Adds build instructions for Hetzner Cloud images.
Pulls in flatcar/init#118 and flatcar/bootengine#94 in a temporary commit, will be removed once they are merged and used in
main.How to use
The process to setup a server using these changes is described here: https://github.com/apricote/flatcar-packer-hcloud/blob/oem-image/README.md
Testing done
I have built the image from this PR (based on an earlier nightly tag) and created a Hetzner Cloud server from it. I have tested the following (custom) functionality:
For the usual Hetzner Cloud OS images, there is some "magic" happening through hc-utils which is not included in this PR. I have not tested any functionality related to this.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.