OpenStack: Changed metadata hostname source order#2010
Conversation
|
Hello @alejandro-ripoll, You need to readd to the commit the correct CROSS WORKON ID for the bootengine: flatcar/bootengine@fb2631c. Also, the changelog entry needs to reflect the correct PR ID and the commit message needs to be smaller and in the commit description to add the necessary links / what has been changed. Thank you. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/9412376784 |
Change `flatcar-openstack-hostname.service` to use afterburn `openstack` provider implemented on coreos/afterburn#462 instead of `openstack-metadata`. BootEngine PR: flatcar/bootengine#96
Thanks @ader1990 and @tormath1. I think it should be alright now. |
tormath1
left a comment
There was a problem hiding this comment.
Looks perfect. Thanks for your first contribution!
|
picked to:
|
OpenStack: Changed metadata hostname source order
Change
flatcar-openstack-hostname.serviceto use afterburnopenstackprovider implemented on coreos/afterburn#462 instead ofopenstack-metadata.Closes: flatcar/Flatcar#1445
BootEngine PR: flatcar/bootengine#96
Superseeds #2009
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.