sys-kernel/coreos-modules: disable CONFIG_NFS_V4_2_READ_PLUS#2390
Merged
sys-kernel/coreos-modules: disable CONFIG_NFS_V4_2_READ_PLUS#2390
Conversation
Disable CONFIG_NFS_V4_2_READ_PLUS kernel config, as Linux kernel >= 6.6 enabled the CONFIG_NFS_V4_2_READ_PLUS config option by default, and nfs-ganesha version <= 6.1 is broken due to mishandling of the read_plus operation. See: nfs-ganesha/nfs-ganesha@24da5c3 See: flatcar/Flatcar#1565 See: nfs-ganesha/nfs-ganesha#1188
ader1990
force-pushed
the
ader1990/fix-nfs-read-plus
branch
from
7a1ff9a to
73afa5e
Compare
tormath1
reviewed
Oct 22, 2024
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/11461654903 |
Member
|
Do we want to reenable this CONFIG at some point? |
Contributor
Author
Maybe, I have not tried/found yet a nfs-ganesha version that fixes the issue, as it is not released yet, waiting for kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#152 |
Contributor
Author
|
But even if the nfs-ganesha is fixed, as the possible fix landed a few days ago, it is safe to assume that we need to backport this change into the /stable/beta/alpha Flatcar versions. |
jepio
approved these changes
Oct 30, 2024
This was referenced Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable CONFIG_NFS_V4_2_READ_PLUS kernel config, as Linux kernel >= 6.6 enabled the CONFIG_NFS_V4_2_READ_PLUS config option by default, and nfs-ganesha version <= 6.1 is broken due to mishandling of the read_plus operation.
See:
nfs-ganesha/nfs-ganesha@24da5c3
See: flatcar/Flatcar#1565
See: nfs-ganesha/nfs-ganesha#1188
Testing done
Manually checked on a two node K8S cluster that the issue is no longer present when CONFIG_NFS_V4_2_READ_PLUS=n.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.