Skip to content

Comments

portage-stable, azure-oem: add inotify-tools, urllib3 to azure OEM#3116

Merged
t-lo merged 1 commit intomainfrom
t-lo/azure-oem-add-inotify-urllib
Jul 16, 2025
Merged

portage-stable, azure-oem: add inotify-tools, urllib3 to azure OEM#3116
t-lo merged 1 commit intomainfrom
t-lo/azure-oem-add-inotify-urllib

Conversation

@t-lo
Copy link
Member

@t-lo t-lo commented Jul 16, 2025

This change adds inotify-tools to portage-stable, and to the azure OEM sysext. It also adds urllib3 to the azure OEM sysext.

Both are added to satisfy optional dependencies in Azure cloud.

Testing done

  • built packages and the generic image: build succeeded
  • built the azure OEM image: build succeeded
  • built the qemu_uefi image to test the new features locally (manual test)
    • used the bakery boot feature to start the qemu image locally with azure-oem sysext merged
    • tested urllib3 availability in Python:
    python
    >>> import urllib3
    >>> dir(urllib3)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              
    ['BaseHTTPResponse', 'HTTPConnectionPool', 'HTTPHeaderDict', 'HTTPResponse', 'HTTPSConnectionPool', 'PoolManager', 'ProxyManager', 'Retry', 'Timeout', '_DEFAULT_POOL', '_TYPE_BODY', '_TYPE_FIELDS', '__all__', '__author__', '__builtins__', '__cached__', '__doc__', '__file__', '__license__', '__loader__', '__name__', '__package__', '__path__', '__spec__', '__version__', '_base_connection', '_collections', '_request_methods', '_version', 'add_stderr_logger', 'annotations', 'connection', 'connection_from_url', 'connectionpool', 'disable_warnings', 'encode_multipart_formdata', 'exceptions', 'fields', 'filepost', 'http2', 'logging', 'make_headers', 'poolmanager', 'proxy_from_url', 'request', 'response', 'ssl', 'sys', 'typing', 'util', 'warnings']
      >>> urllib3.__version__
    '2.5.0'
    • tested inotifywait:
    $  touch test
    $  { sleep 10; echo "hello">test; } &
    $ inotifywait test
    Setting up watches.
    Watches established.
    test OPEN
    

@t-lo t-lo requested review from a team and jepio July 16, 2025 07:34
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we add a changelog entry as well? Something like: azure: added inotify-tools

This change adds inotify-tools to portage-stable, and to the azure OEM
sysext. It also adds urllib3 to the azure OEM sysext.

Both are added to satisfy optional dependencies in Azure cloud.

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo t-lo force-pushed the t-lo/azure-oem-add-inotify-urllib branch from bce52d3 to b65b48d Compare July 16, 2025 07:58
@t-lo t-lo temporarily deployed to development July 16, 2025 07:58 — with Image GitHub Actions Inactive
@t-lo t-lo requested a review from tormath1 July 16, 2025 07:58
@t-lo
Copy link
Member Author

t-lo commented Jul 16, 2025

All feedback addressed. Thank you for the swift review, Mathieu!

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

Build action triggered: https://github.com/flatcar/scripts/actions/runs/16319272961

Copy link
Contributor

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick!

@t-lo
Copy link
Member Author

t-lo commented Jul 16, 2025

Tests are green, merging.

@t-lo t-lo merged commit f4e0141 into main Jul 16, 2025
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Testing / in Review to Implemented in Flatcar tactical, release planning, and roadmap Jul 16, 2025
@t-lo t-lo deleted the t-lo/azure-oem-add-inotify-urllib branch July 16, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants