Support the /boot/coreos/first_boot flag file#68
Merged
pothos merged 1 commit intoflatcar-masterfrom May 22, 2020
Merged
Conversation
build_library/grub.cfg
Outdated
| set first_boot="flatcar.first_boot=detected" | ||
| fi | ||
| if [ -f "($root)/coreos/first_boot" ]; then | ||
| set first_boot="coreos.first_boot=detected" |
Contributor
There was a problem hiding this comment.
Why set coreos.first_boot instead of flatcar.first_boot?
Member
Author
There was a problem hiding this comment.
On one hand because it allows us to test this parameter and on the other because we could in the future give a deprecation warning for the old flag file location.
Contributor
There was a problem hiding this comment.
The flag file location is separate from the grub command line parameter. I don't think it's good to add now a command line parameter that we don't intend to support.
Member
Author
There was a problem hiding this comment.
We indent to support for now it because we aim to be a drop-in replacement.
Member
Author
There was a problem hiding this comment.
But sure, I can remove it here as it's an internal thing.
If a user or old software creates the flag file on the old CoreOS location, nothing would happen. Check the old location, too, so that Ignition is rerun.
pothos
force-pushed
the
kai/coreos-first-boot
branch
from
c8a4589 to
f4aa56a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user or old software creates the flag file on the old CoreOS location,
nothing would happen.
Check the old location, too, so that Ignition is rerun.
How to use
Requires flatcar/bootengine#13 and flatcar/update_engine#5
Build available here:
Testing done
./flatcar_production_qemu.shmkdir /boot/coreos; touch /boot/coreos/first_boot./flatcar_production_qemu.sh -i someconfig.ign