Skip to content

Comments

Update commonconfig-6.1 to build kernel with TLS module#865

Merged
dongsupark merged 2 commits intoflatcar:mainfrom
krishjainx:patch-1
Jun 15, 2023
Merged

Update commonconfig-6.1 to build kernel with TLS module#865
dongsupark merged 2 commits intoflatcar:mainfrom
krishjainx:patch-1

Conversation

@krishjainx
Copy link
Contributor

@krishjainx krishjainx commented Jun 1, 2023

This pull request aims to modify commonconfig-6.1 in order to incorporate a TLS module for kernel building. By integrating the TLS module, applications and containers will have the ability to offload TLS processing to the kernel.

Fixes flatcar/Flatcar#995

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/1992/cldsv/

@jepio
Copy link
Member

jepio commented Jun 2, 2023

Can you please also fix the format of the commit message: sys-kernel/coreos-modules: Enable TLS support as a module

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/5280553616

Allow one to TLS software offload to the kernel. Configured as module to
not increase default kernel size for something rarely used.
@krishjainx
Copy link
Contributor Author

Done @jepio

@krishjainx krishjainx temporarily deployed to development June 2, 2023 11:47 — with Image GitHub Actions Inactive
@krishjainx krishjainx temporarily deployed to development June 2, 2023 11:47 — with Image GitHub Actions Inactive
@dongsupark dongsupark added the main label Jun 2, 2023
@dongsupark dongsupark mentioned this pull request Jun 5, 2023
@dongsupark
Copy link
Member

Added Fixes https://github.com/flatcar/Flatcar/issues/995 in the description, so that merging this PR can close the issue as well.

@dongsupark
Copy link
Member

@dongsupark
Copy link
Member

Jenkins CI passed. So let's ignore the flaky failures from Github Actions.

One last missing piece is changelog.
Every PR should have a separate commit that contains changelog to be automatically collected by the next release process, for creating release notes.
In your case, create a new file like changelog/changes/2023-06-15-kernel-tls.md, and in that file simply write a line like - Added TLS Kernel module ([scripts#865](https://github.com/flatcar/scripts/pull/865)).

See also https://github.com/flatcar/scripts/blob/main/changelog/README.md.

@krishjainx
Copy link
Contributor Author

Done @dongsupark

Copy link
Member

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] Enable Kernel TLS

3 participants