Detect multipart mime and ignore it#873
Merged
gabriel-samfira merged 3 commits intomainfrom Jun 9, 2023
Merged
Conversation
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5219795607 |
pothos
reviewed
Jun 8, 2023
Member
pothos
left a comment
There was a problem hiding this comment.
This needs a changelog entry and the commit IDs should point to merge commits, i.e., first merge the other PRs.
Member
Author
I will gladly change the commits and add the changelog once the coreos-cloudinit and mantle PRs merge 😄. Just need some LGTMs on them. |
792f1e5 to
008d48f
Compare
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
008d48f to
de652ae
Compare
krnowak
reviewed
Jun 9, 2023
...ner/src/third_party/coreos-overlay/coreos-base/coreos-cloudinit/coreos-cloudinit-9999.ebuild
Show resolved
Hide resolved
...rlay/sys-apps/ignition/files/0013-config-util-add-cloud-init-detection-to-initial-pars.patch
Show resolved
Hide resolved
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Member
Author
|
@krnowak changes made. Do you think it's worth running the test workflows again? |
Member
Cool, thanks!
Nah. |
krnowak
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect multipart mime user-data
This change makes ignition ignore user-data that is multipart mime.
How to use
Deploy a VM and add multipart mime userdata. If the VM boots, it works.
Testing done
Deployed a VM on OpenStack and set its userdata to a multipart mime userdata. The VM succeeded to boot.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.Replaces: #823
/update-sdk