Skip to content

Comments

Detect multipart mime and ignore it#873

Merged
gabriel-samfira merged 3 commits intomainfrom
gabriel-samfira/detect-multipart-mime
Jun 9, 2023
Merged

Detect multipart mime and ignore it#873
gabriel-samfira merged 3 commits intomainfrom
gabriel-samfira/detect-multipart-mime

Conversation

@gabriel-samfira
Copy link
Member

@gabriel-samfira gabriel-samfira commented Jun 2, 2023

Detect multipart mime user-data

This change makes ignition ignore user-data that is multipart mime.

How to use

Deploy a VM and add multipart mime userdata. If the VM boots, it works.

Testing done

Deployed a VM on OpenStack and set its userdata to a multipart mime userdata. The VM succeeded to boot.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Replaces: #823

/update-sdk

@gabriel-samfira gabriel-samfira temporarily deployed to development June 2, 2023 13:48 — with Image GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/5219795607

@gabriel-samfira gabriel-samfira temporarily deployed to development June 2, 2023 23:39 — with Image GitHub Actions Inactive
@gabriel-samfira gabriel-samfira temporarily deployed to development June 3, 2023 00:22 — with Image GitHub Actions Inactive
@gabriel-samfira gabriel-samfira temporarily deployed to development June 7, 2023 10:47 — with Image GitHub Actions Inactive
@gabriel-samfira gabriel-samfira temporarily deployed to development June 7, 2023 11:53 — with Image GitHub Actions Inactive
@gabriel-samfira gabriel-samfira temporarily deployed to development June 7, 2023 12:53 — with Image GitHub Actions Inactive
@gabriel-samfira gabriel-samfira temporarily deployed to development June 7, 2023 13:45 — with Image GitHub Actions Inactive
@gabriel-samfira gabriel-samfira temporarily deployed to development June 7, 2023 14:27 — with Image GitHub Actions Inactive
@gabriel-samfira gabriel-samfira temporarily deployed to development June 7, 2023 15:58 — with Image GitHub Actions Inactive
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changelog entry and the commit IDs should point to merge commits, i.e., first merge the other PRs.

@gabriel-samfira
Copy link
Member Author

This needs a changelog entry and the commit IDs should point to merge commits, i.e., first merge the other PRs.

I will gladly change the commits and add the changelog once the coreos-cloudinit and mantle PRs merge 😄. Just need some LGTMs on them.

@gabriel-samfira gabriel-samfira force-pushed the gabriel-samfira/detect-multipart-mime branch from 792f1e5 to 008d48f Compare June 8, 2023 19:41
@gabriel-samfira gabriel-samfira temporarily deployed to development June 8, 2023 19:41 — with Image GitHub Actions Inactive
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
@gabriel-samfira gabriel-samfira force-pushed the gabriel-samfira/detect-multipart-mime branch from 008d48f to de652ae Compare June 8, 2023 20:57
@gabriel-samfira gabriel-samfira temporarily deployed to development June 8, 2023 20:57 — with Image GitHub Actions Inactive
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
@gabriel-samfira
Copy link
Member Author

@krnowak changes made. Do you think it's worth running the test workflows again?

@krnowak
Copy link
Member

krnowak commented Jun 9, 2023

@krnowak changes made.

Cool, thanks!

Do you think it's worth running the test workflows again?

Nah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants