pkg/tar: ignore EOPNOTSUPP from return value of Setxattr for Stable/Beta/Alpha#2
Merged
dongsupark merged 1 commit intoflatcar-masterfrom Dec 4, 2019
Merged
Conversation
In some cases, docker service does not start, because torcx is not able to unpack tarball like the following error: ``` failed to unpack: unpacking \"/usr/share/torcx/store/docker:com.coreos.cl.torcx.tgz\": error extracting tar: operation not supported" image=docker reference=com.coreos.cl ``` This means `Setxattr()` returns EOPNOTSUPP, especially when SELinux is disabled on the host. To work around the issue, let's ignore EOPNOTSUPP.
iaguis
approved these changes
Oct 31, 2019
Member
iaguis
left a comment
iaguis
left a comment
There was a problem hiding this comment.
LGTM.
I've built this, tested on a machine with SELINUX=disabled and it worked for me.
dongsupark
force-pushed
the
dongsu/fix-setxattr-eopnotsupp
branch
from
758eed6 to
fe37695
Compare
dongsupark
changed the title
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 4, 2019
To fix the recent Setxattr issue in torcx, bump torcx to the latest commit. See also flatcar/torcx#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, docker service does not start, because torcx is not able to unpack tarball like the following error:
This means
Setxattr()returns EOPNOTSUPP, especially when SELinux is disabled on the host.To work around the issue, let's ignore EOPNOTSUPP.