Skip to content

Comments

Add parameters to specify target filename#49

Merged
pothos merged 1 commit intotrunkfrom
kai/target-filename
Jan 18, 2024
Merged

Add parameters to specify target filename#49
pothos merged 1 commit intotrunkfrom
kai/target-filename

Conversation

@pothos
Copy link
Member

@pothos pothos commented Jan 16, 2024

When a match pattern has to be used, the resulting filename in the output directory is unknown.
Add parameters to take only the first match and use a particular name for the extracted target file.

How to use

Should fix the problem with self-hosted update payloads.

Testing done

In scripts PR with Flatcar and also manual:

target/debug/download_sysext -p ~/kinvolk/scripts/sdk_container/src/third_party/coreos-overlay/coreos-base/coreos-au-key/files/official-v2.pub.pem -m "*oem-azure.gz" -o /var/tmp/outdir/ -i /var/tmp/beta-response-local -v -n oem-azure.raw -t

where the XML has entries like <package name="extrafile-amd64-3815.0.0-oem-ami.gz" …

@pothos pothos requested a review from dongsupark January 16, 2024 18:49
pothos added a commit to flatcar/scripts that referenced this pull request Jan 16, 2024
This pulls in flatcar/ue-rs#49 and
flatcar/update_engine#36 to fix the handling
of OEM update payloads in a Nebraska response with self-hosted packages.
Before this fix the processing failed and had to rely on the fallback
download from the release server.
When a match pattern has to be used, the resulting filename in the
output directory is unknown.
Add parameters to take only the first match and use a particular name
for the extracted target file.
@pothos pothos force-pushed the kai/target-filename branch from 591faf2 to eaf8149 Compare January 17, 2024 11:40
@pothos pothos merged commit fa5202f into trunk Jan 18, 2024
@pothos pothos deleted the kai/target-filename branch January 18, 2024 10:51
pothos added a commit to flatcar/scripts that referenced this pull request Jan 18, 2024
This pulls in flatcar/ue-rs#49 and
flatcar/update_engine#36 to fix the handling
of OEM update payloads in a Nebraska response with self-hosted packages.
Before this fix the processing failed and had to rely on the fallback
download from the release server.
pothos added a commit to flatcar/scripts that referenced this pull request Jan 18, 2024
This pulls in flatcar/ue-rs#49 and
flatcar/update_engine#36 to fix the handling
of OEM update payloads in a Nebraska response with self-hosted packages.
Before this fix the processing failed and had to rely on the fallback
download from the release server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants