flatcar-postinst: Support updating old airgapped clients#38
Merged
pothos merged 1 commit intoflatcar-masterfrom Feb 12, 2024
Merged
flatcar-postinst: Support updating old airgapped clients#38pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
pothos
force-pushed
the
kai/support-old-airgapped
branch
from
83875b6 to
c4cd480
Compare
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 8, 2024
This pulls in flatcar/update_engine#38 with two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs, because the XML passing and the passing of proxy env vars is not present in old clients.
2 tasks
The XML passing and the passing of proxy env vars is required for updating old airgapped clients because we need to support custom non-public payload URLs and/or go through a proxy. However, these changes are part of update-engine itself and thus are not present in old clients. This blocks updating to the latest Stable. Add two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs.
pothos
force-pushed
the
kai/support-old-airgapped
branch
from
c4cd480 to
ae5044e
Compare
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 9, 2024
This pulls in flatcar/update_engine#38 with two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs, because the XML passing and the passing of proxy env vars is not present in old clients.
krnowak
approved these changes
Feb 12, 2024
Member
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
Had to run these commands in a Flatcar VM to figure out what they are exactly doing. TIL about `\K'. :)
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/update_engine#38 with two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs, because the XML passing and the passing of proxy env vars is not present in old clients.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/update_engine#38 with two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs, because the XML passing and the passing of proxy env vars is not present in old clients.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/update_engine#38 with two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs, because the XML passing and the passing of proxy env vars is not present in old clients.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 12, 2024
This pulls in flatcar/update_engine#38 with two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs, because the XML passing and the passing of proxy env vars is not present in old clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML passing and the passing of proxy env vars is required for updating old airgapped clients because we need to support custom non-public payload URLs and/or go through a proxy. However, these changes are part of update-engine itself and thus are not present in old clients. This blocks updating to the latest Stable.
Add two workarounds to read out proxy env vars from the service unit and to read out the XML response from the journal logs.
How to use
Backport to Stable
Testing done
Jenkins
Tested running the commands manually.
Tested the "inverse" with an invalid proxy env var added while the update-engine service is running to see that the variable gets read in from the postinst action and it is thus by not being able to fetch.
Tested with removing default route while running flatcar-update, to verify that it doesn't use the fallback case.