postinst: fix the removal of all extensions#51
Merged
pothos merged 1 commit intoflatcar:mainfrom Oct 10, 2025
Merged
Conversation
When upgrading to a new version, if there are two or more extensions enabled, all extensions are deleted due to incorrect verification logic. Only the last downloaded extension remains. This makes it impossible to boot the system after a reboot in closed environments due to lack of access to https://update.release.flatcar-linux.net Signed-off-by: Sergey Garaev <sergeygaraev2019@gmail.com>
pothos
approved these changes
Oct 10, 2025
Member
pothos
left a comment
There was a problem hiding this comment.
Thanks a lot!
Yes, that logic was copy pasted from the OEM case where there is only one but of course it won't work in the loop…
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 10, 2025
Pulls in flatcar/update_engine#51 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
2 tasks
Member
|
I plan to backport this, and hope that not too many things have changed 🤞 since Stable |
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 13, 2025
Pulls in flatcar/update_engine#51 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 14, 2025
Pulls in flatcar/update_engine#51 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 14, 2025
Pulls in flatcar/update_engine#51 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading to a new version, if there are two or more extensions enabled, all extensions are deleted due to incorrect verification logic. Only the last downloaded extension remains. This makes it impossible to boot the system after a reboot in closed environments due to lack of access to https://update.release.flatcar-linux.net
How to use
Testing done
An image was created in the flatcar-4426 branch, which was added with extensions to the local nginx file server. The package was created on the local nebraska server.
With extensions enabled:
Without extensions enabled:
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.