Skip to content

Improved displaying floats as strings#1030

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/float-to-string
Mar 29, 2024
Merged

Improved displaying floats as strings#1030
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/float-to-string

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Improved displaying floats as strings

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.282mb +0.00%  | 823.220ms +0.37% | ±0.83% +50.48%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.005mb +0.00%   | 340.872ms -0.17% | ±2.61% +726.74% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.156mb +0.01%   | 1.044s +1.27%    | ±0.14% -88.41%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.831mb +0.00% | 896.732ms +0.07% | ±0.15% -83.06%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.913mb +0.01%   | 35.815ms +3.31%  | ±0.90% -34.69%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.919mb +0.01%   | 435.428ms +0.83% | ±0.26% -72.08%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.619mb +0.00% | 62.672ms -3.85% | ±0.75% -52.55% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.662mb +0.00%  | 470.230ms -0.95% | ±0.14% -83.66%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.144mb +0.00%  | 72.248ms -0.37%  | ±0.33% -64.03%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.570mb +0.00% | 51.990ms -3.39%  | ±0.27% -82.33%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 224.393mb +0.00% | 1.429s +0.35%    | ±0.56% -47.40%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.960mb +0.00%  | 39.983ms +0.53%  | ±0.50% +210.96% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.686mb +0.00%  | 3.287ms -3.45%   | ±0.16% -89.97%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.413mb +0.00%  | 181.391ms -0.73% | ±0.82% +6.08%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.938mb +0.00%  | 18.012ms -1.68%  | ±0.91% -43.67%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.926mb +0.00%  | 1.736ms +1.65%   | ±1.85% +63.48%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.926mb +0.00%  | 1.685ms +0.91%   | ±1.48% -50.69%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.038mb +0.00%  | 2.541ms +0.70%   | ±1.95% +541.06% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.567mb +0.00%  | 14.733ms +2.45%  | ±0.77% -68.23%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.567mb +0.00%  | 14.818ms +2.60%  | ±0.81% +422.88% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.471mb +0.00%  | 1.606μs -10.47%  | ±2.89% +8.16%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.471mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.025mb +0.00%  | 12.896ms -0.13%  | ±0.90% +163.71% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.386mb +0.00% | 63.143ms -2.49%  | ±2.01% +71.55%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.086mb +0.00%  | 1.248ms -7.00%   | ±1.01% -55.10%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.433mb +0.00%  | 59.046ms +0.79%  | ±0.65% -51.74%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.188mb +0.00%  | 3.835ms +1.01%   | ±0.36% +26.03%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.549mb +0.00%  | 39.828ms -1.67%  | ±0.71% +325.48% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.550mb +0.00%  | 39.935ms -4.88%  | ±3.46% +8.42%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.549mb +0.00%  | 40.746ms -6.64%  | ±1.27% +19.02%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.912mb +0.00%  | 7.471ms -7.85%   | ±0.87% -45.44%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.471mb +0.00%  | 28.655ms -7.03%  | ±0.77% +60.81%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.471mb +0.00%  | 13.079μs -6.44%  | ±0.95% -21.41%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.471mb +0.00%  | 15.888μs -5.21%  | ±0.60% -65.04%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.479mb +0.00%  | 185.398ms -0.80% | ±0.28% -41.96%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.717mb +0.00% | 487.988ms -1.65% | ±0.48% -3.57%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.196mb +0.00%  | 242.673ms -4.03% | ±1.01% -10.93%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.130mb +0.00%  | 51.474ms -4.42%  | ±2.20% +18.02%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.961mb +0.00%  | 426.447ms -2.79% | ±0.49% -48.62%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.500mb +0.00%  | 85.138ms -3.46%  | ±0.91% +83.38%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 00e5816 into flow-php:1.x Mar 29, 2024
@norberttech norberttech deleted the feature/float-to-string branch May 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant