Skip to content

Fixed type value validation for nullable types#1040

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/fields-nullability
Apr 5, 2024
Merged

Fixed type value validation for nullable types#1040
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/fields-nullability

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • type value validation for nullable types

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev           |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.295mb +0.01%  | 846.582ms -1.05% | ±0.51% -26.61%   |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.016mb +0.03%   | 346.604ms +0.35% | ±2.87% +1484.11% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.170mb +0.04%   | 1.078s -0.22%    | ±0.18% -93.31%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.837mb +0.00% | 922.105ms +2.35% | ±1.10% +286.63%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.926mb +0.03%   | 35.336ms +0.25%  | ±0.12% -19.91%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.932mb +0.03%   | 435.120ms +0.20% | ±0.92% +275.61%  |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.237mb +0.00% | 61.545ms +1.20% | ±2.93% +178.12% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 96.681mb +0.00%  | 465.607ms +0.47% | ±0.67% +20.42%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.160mb +0.00%  | 71.448ms +2.16%  | ±0.50% +3.16%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 107.590mb +0.00% | 50.753ms -0.13%  | ±0.33% -25.24%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 227.005mb +0.00% | 1.418s +0.34%    | ±0.27% +205.81% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.973mb +0.01%  | 40.334ms +1.16%  | ±0.46% +36.69%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.058mb +0.00%  | 3.356ms +3.06%   | ±1.68% -24.45%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.656mb +0.00% | 189.821ms +1.84% | ±1.33% +37.78%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.376mb +0.00%  | 18.867ms -0.73%  | ±1.58% +1686.55% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.298mb +0.00%  | 1.600ms -3.81%   | ±3.20% +1664.80% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.298mb +0.00%  | 1.698ms +1.02%   | ±1.06% +13.01%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.410mb +0.00%  | 2.587ms +1.21%   | ±2.74% +1243.47% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.939mb +0.00%  | 16.637ms +6.15%  | ±0.20% -89.54%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.939mb +0.00%  | 16.558ms +4.65%  | ±1.57% -5.50%    |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.843mb +0.00%  | 1.706μs +0.72%   | ±2.72% -3.85%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.843mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00%  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.193mb +0.00%  | 12.528ms -0.71%  | ±1.16% +122.81%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.564mb +0.00% | 62.198ms +0.79%  | ±0.44% -47.55%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.459mb +0.00%  | 1.210ms +0.03%   | ±3.02% +44.55%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.805mb +0.00%  | 63.891ms +3.40%  | ±1.47% -54.67%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.560mb +0.00%  | 3.819ms -0.80%   | ±0.19% -90.17%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.986mb +0.00%  | 40.020ms -1.93%  | ±0.99% -21.71%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.987mb +0.00%  | 40.092ms -1.51%  | ±0.59% +153.88%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.986mb +0.00%  | 40.492ms +0.82%  | ±0.32% -83.86%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.284mb +0.00%  | 7.432ms +1.12%   | ±0.13% -84.66%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.843mb +0.00%  | 29.053ms +0.84%  | ±0.72% -52.06%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.843mb +0.00%  | 13.300μs -0.18%  | ±0.00% -100.00%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.843mb +0.00%  | 15.780μs +1.80%  | ±1.07% +103.36%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.657mb +0.00% | 193.136ms -0.51% | ±0.66% -61.94%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.968mb +0.00%  | 435.263ms +1.79% | ±0.59% -9.89%    |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.507mb +0.01%  | 85.470ms +1.07%  | ±0.61% -14.34%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.735mb +0.00% | 522.940ms +1.77% | ±0.33% -17.82%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.213mb +0.00%  | 260.437ms +0.86% | ±0.95% -18.74%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.148mb +0.01%  | 55.476ms +1.41%  | ±0.17% -86.52%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 814c6c4 into flow-php:1.x Apr 5, 2024
@norberttech norberttech deleted the bug/fields-nullability branch May 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant