Skip to content

Allow to use max/min aggregations on date time columns#1083

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/max-min-datetime
May 24, 2024
Merged

Allow to use max/min aggregations on date time columns#1083
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/max-min-datetime

Conversation

@norberttech
Copy link
Member

Change Log

Added

  • Allow to use max/min aggregations on date time columns

Fixed

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.448mb +0.00%  | 823.183ms -0.76% | ±0.49% -13.55% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.167mb +0.01%   | 335.734ms -0.10% | ±0.23% -68.70% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.200mb +0.01%   | 1.065s -0.17%    | ±0.45% -77.93% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.871mb +0.00% | 894.937ms -1.01% | ±0.87% +3.72%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.957mb +0.01%   | 35.495ms -2.74%  | ±1.55% -17.11% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.963mb +0.01%   | 435.512ms -0.44% | ±0.72% +40.62% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.265mb +0.00% | 60.278ms +2.26% | ±1.80% +406.56% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+------------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev           |
+--------------------+----------------+------+-----+------------------+------------------+------------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 96.834mb +0.00%  | 451.961ms -1.77% | ±1.53% +20.30%   |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.246mb +0.00%  | 68.497ms -1.00%  | ±1.38% +301.57%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 107.620mb +0.00% | 51.132ms -0.18%  | ±1.39% +4894.16% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 227.039mb +0.00% | 1.407s -0.90%    | ±0.57% -23.87%   |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.001mb +0.00%  | 38.688ms -0.12%  | ±0.90% +121.35%  |
+--------------------+----------------+------+-----+------------------+------------------+------------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.083mb +0.00%  | 4.012ms +20.85%  | ±0.75% -77.19%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.681mb +0.00% | 188.263ms -1.69% | ±0.34% -72.17%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.401mb +0.00%  | 19.121ms -2.11%  | ±0.99% +104.22%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.323mb +0.00%  | 1.870ms +8.50%   | ±2.68% +101.25%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.323mb +0.00%  | 1.810ms +3.89%   | ±2.33% -32.07%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.435mb +0.00%  | 3.010ms +8.34%   | ±3.42% +170.80%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.964mb +0.00%  | 19.193ms +7.52%  | ±2.20% +89.19%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.964mb +0.00%  | 18.877ms +5.94%  | ±2.46% +320.81%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.868mb +0.00%  | 1.794μs +5.15%   | ±2.67% -1.89%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.868mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.218mb +0.00%  | 12.575ms +0.83%  | ±0.76% -73.08%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.589mb +0.00% | 61.858ms -0.10%  | ±1.69% +145.85%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.484mb +0.00%  | 1.803ms +16.17%  | ±2.39% +16.18%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.831mb +0.00%  | 67.081ms +5.28%  | ±1.02% +30.48%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.585mb +0.00%  | 4.597ms +2.02%   | ±2.79% +99.99%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.012mb +0.00%  | 40.347ms +2.37%  | ±1.42% +0.57%    |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.012mb +0.00%  | 40.355ms +3.61%  | ±2.46% +88.56%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.012mb +0.00%  | 40.121ms +1.18%  | ±1.28% +84.11%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.309mb +0.00%  | 7.623ms +2.92%   | ±0.95% -18.31%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.868mb +0.00%  | 29.182ms +2.27%  | ±1.72% +3026.51% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.868mb +0.00%  | 14.179μs +6.71%  | ±0.88% -55.15%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.868mb +0.00%  | 16.420μs +1.73%  | ±1.04% -33.11%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.682mb +0.00% | 191.205ms -2.00% | ±1.17% +259.03%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.813mb +0.00% | 497.781ms +0.91% | ±0.68% -42.64%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.291mb +0.00%  | 253.594ms +0.73% | ±1.47% -57.80%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.225mb +0.00%  | 54.696ms +1.71%  | ±0.31% -80.69%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.996mb +0.00%  | 428.808ms -1.58% | ±0.83% -74.52%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.535mb +0.00%  | 86.109ms -0.82%  | ±0.99% -66.15%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit e5bbefe into flow-php:1.x May 24, 2024
@norberttech norberttech deleted the feature/max-min-datetime branch December 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant