Skip to content

Fix for extracting XML attribute#1084

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:bugfix/xml-attr
May 25, 2024
Merged

Fix for extracting XML attribute#1084
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:bugfix/xml-attr

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented May 25, 2024

Change Log

Added

Fixed

  • Fix for extracting XML attribute

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.448mb +0.00%  | 834.499ms +0.94% | ±0.53% +45.33%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.167mb +0.01%   | 338.124ms -0.53% | ±0.51% -10.37%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.200mb +0.01%   | 1.087s +1.31%    | ±1.40% +341.31% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.871mb +0.00% | 911.955ms +0.69% | ±1.69% +58.99%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.957mb +0.01%   | 35.716ms -1.81%  | ±1.97% +117.33% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.963mb +0.01%   | 431.393ms -1.63% | ±0.76% +181.25% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.265mb +0.00% | 60.104ms +1.77% | ±1.14% +575.50% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 96.834mb +0.00%  | 454.946ms +0.48% | ±1.20% +315.27% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.246mb +0.00%  | 68.343ms +0.48%  | ±0.52% -17.63%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 107.620mb +0.00% | 52.382ms +1.56%  | ±0.39% -1.03%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 227.039mb +0.00% | 1.435s +2.66%    | ±1.63% +11.60%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.001mb +0.00%  | 38.677ms -0.10%  | ±0.56% -10.20%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.083mb +0.00%  | 3.547ms +3.90%   | ±1.83% -22.92%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.681mb +0.00% | 187.252ms -1.96% | ±0.06% -93.99%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.401mb +0.00%  | 19.238ms -1.13%  | ±2.43% +446.24%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.323mb +0.00%  | 1.990ms +19.34%  | ±1.06% -14.19%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.323mb +0.00%  | 1.927ms +15.21%  | ±0.06% -86.68%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.435mb +0.00%  | 3.060ms +10.67%  | ±1.66% -18.75%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.964mb +0.00%  | 16.615ms -17.17% | ±2.49% +3839.09% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.964mb +0.00%  | 16.803ms -14.44% | ±0.73% -81.31%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.868mb +0.00%  | 1.706μs 0.00%    | ±2.72% 0.00%     |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.868mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.218mb +0.00%  | 12.432ms +0.42%  | ±3.37% +266.69%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.589mb +0.00% | 61.113ms +0.60%  | ±0.46% +0.05%    |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.484mb +0.00%  | 1.587ms +33.08%  | ±2.07% +118.36%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.831mb +0.00%  | 65.736ms +3.04%  | ±0.73% -37.58%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.585mb +0.00%  | 4.367ms +8.38%   | ±3.09% +378.03%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.012mb +0.00%  | 39.344ms -1.08%  | ±0.75% -34.34%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.012mb +0.00%  | 39.957ms +1.00%  | ±0.16% -83.38%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.012mb +0.00%  | 39.137ms -11.92% | ±0.52% +40.83%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.309mb +0.00%  | 7.350ms -3.53%   | ±1.28% -28.79%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.868mb +0.00%  | 28.721ms -1.14%  | ±0.58% -5.05%    |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.868mb +0.00%  | 13.312μs +0.71%  | ±0.71% -33.67%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.868mb +0.00%  | 16.334μs +2.72%  | ±1.26% +22.99%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.682mb +0.00% | 193.004ms -0.87% | ±0.57% -14.80%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.813mb +0.00% | 503.056ms +1.13% | ±1.03% -5.33%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.291mb +0.00%  | 253.856ms +1.48% | ±0.84% +6.59%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.225mb +0.00%  | 54.250ms -5.14%  | ±2.57% -14.06%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.996mb +0.00%  | 440.140ms +1.65% | ±1.00% -51.06%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.535mb +0.00%  | 92.507ms +6.38%  | ±3.28% -2.35%    |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit de1db74 into flow-php:1.x May 25, 2024
@stloyd stloyd deleted the bugfix/xml-attr branch May 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants