Skip to content

Fixed invalid map type detection#1161

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/detecting-map-structures
Jul 31, 2024
Merged

Fixed invalid map type detection#1161
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/detecting-map-structures

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Fixed invalid map type detection

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 3.949mb +0.12%  | 510.102ms -0.33% | ±0.27% -88.84%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 3.981mb +2.63%  | 1.065s +0.18%    | ±0.61% +168.90% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 28.544mb +0.00% | 436.759ms +1.81% | ±0.12% -78.08%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 3.708mb +0.13%  | 34.000ms -1.98%  | ±1.65% -24.44%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 3.655mb +0.13%  | 440.182ms +0.63% | ±2.45% +671.66% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.050mb +0.00% | 61.578ms -0.29% | ±0.41% -58.56% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev          |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.171mb +0.01%  | 86.607ms +0.63% | ±2.00% +109.03% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.538mb -3.79% | 54.732ms +2.14% | ±1.50% +150.72% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 123.823mb +0.00% | 1.254s +0.65%   | ±0.51% +62.20%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.965mb +0.03%  | 44.517ms -1.43% | ±0.45% -79.32%  |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+-------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode              | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+-------------------+-----------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.719mb -11.86% | 388.122ms -17.62% | ±0.42% -85.54%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.258mb -9.50%  | 77.734ms -14.57%  | ±1.51% -39.26%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.537mb -8.33% | 471.704ms -7.28%  | ±1.01% -14.64%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.015mb -8.04%  | 242.511ms -4.70%  | ±1.65% +49.95%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.949mb -6.18%  | 50.490ms -10.15%  | ±0.41% -55.01%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 86.807mb +0.01%  | 3.384ms -11.97%   | ±2.73% +186.82% |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.408mb +0.00% | 186.490ms -1.53%  | ±1.00% -47.58%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.128mb +0.01%  | 18.794ms -1.56%   | ±1.39% +52.54%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.047mb +0.01%  | 1.885ms -7.49%    | ±2.31% +28.27%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.047mb +0.01%  | 1.743ms -12.51%   | ±1.54% +0.92%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.159mb +0.01%  | 2.611ms -13.16%   | ±2.07% -10.93%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.688mb +0.01%  | 15.079ms -4.53%   | ±0.51% -62.12%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.688mb +0.01%  | 14.983ms -4.98%   | ±2.18% +75.32%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.592mb +0.01%  | 1.800μs -9.73%    | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.592mb +0.01%  | 0.300μs -25.00%   | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 92.942mb +0.00%  | 12.151ms -6.34%   | ±0.27% -83.48%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.313mb +0.00% | 61.708ms -0.22%   | ±0.09% -94.02%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.208mb +0.01%  | 1.385ms -20.52%   | ±2.15% +18.42%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.556mb +0.01%  | 66.212ms -2.80%   | ±1.44% -51.81%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.309mb +0.01%  | 3.851ms -14.70%   | ±2.57% +23.19%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.738mb +0.01%  | 39.193ms -2.42%   | ±0.84% -66.77%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.739mb +0.01%  | 39.551ms +0.44%   | ±0.24% -68.53%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.738mb +0.01%  | 39.802ms -1.01%   | ±1.23% -6.53%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.034mb +0.01%  | 7.417ms -2.06%    | ±0.90% -63.29%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.592mb +0.01%  | 28.687ms -4.54%   | ±0.90% +46.87%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.592mb +0.01%  | 13.712μs -0.68%   | ±1.93% +467.72% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.592mb +0.01%  | 15.880μs -3.43%   | ±1.06% -52.68%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.409mb +0.00% | 189.793ms -2.64%  | ±2.04% +281.32% |
+-------------------------+----------------------------+------+-----+------------------+-------------------+-----------------+

@norberttech norberttech merged commit 2792db6 into flow-php:1.x Jul 31, 2024
@norberttech norberttech deleted the bug/detecting-map-structures branch December 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant